docs: update deprecation note for operation_name#8207
docs: update deprecation note for operation_name#8207mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
junr03
left a comment
There was a problem hiding this comment.
Should we trigger the deprecation warning? Is that possible? I know people rely on the warning way more reliably than reading the release notes.
|
We can't detect the default enum value once the config is converted to proto. So that means we might need to perform a pass at the JSON/YAML level (or hack into jsonpb). I don't know how easy it is in C++. Perhaps, API folks have seen this issue before. |
Can't we just look at the enum value directly and just call into the deprecation warning/stat code? cc @alyssawilk |
|
I think the current deprecated code looks at deprecated fields, not deprecated values. |
|
OK let's merge this and track the improvement in the follow up issue. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Handling deprecated and deprecated-default enum values as part of our config checking. Risk Level: Medium Testing: new unit tests Docs Changes: updated runtime docs Release Notes: reverted envoyproxy#8207 Fixes envoyproxy#8253 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov kuat@google.com
Description: Minor clarification explaining why
operation_name: INGRESSis not triggering the deprecation warnings.Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]