Skip to content

Bring in repokitteh's ownercheck#7743

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
itayd:patch-38
Jul 29, 2019
Merged

Bring in repokitteh's ownercheck#7743
htuch merged 1 commit intoenvoyproxy:masterfrom
itayd:patch-38

Conversation

@itayd
Copy link
Copy Markdown
Contributor

@itayd itayd commented Jul 27, 2019

Description:
Per #7423:

  • When a PR contains changes to api/, @envoyproxy/api-shepherds are notified via a CC comment.
  • When a PR contains changes to api/udpa, @envoyproxy/udpa-wg is notified via a CC comment.
  • An additional GitHub check blocking merge is added that will only be marked as passing once an approval review is received from someone in @envoyproxy/api-shepherds.

Risk Level:
None. But if there is any issue, please revert.

Testing:
In test PRs under different users: #7659

Docs Changes:
None.

Release Notes:
None

Fixes #7423

Signed-off-by: Itay Donanhirsh <itay@bazoo.org>
@itayd
Copy link
Copy Markdown
Contributor Author

itayd commented Jul 27, 2019

/review @htuch

@repokitteh-read-only repokitteh-read-only bot requested a review from htuch July 27, 2019 17:14
@itayd
Copy link
Copy Markdown
Contributor Author

itayd commented Jul 27, 2019

/rk-bless

@repokitteh-read-only
Copy link
Copy Markdown

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #7743 was labeled by repokitteh[bot].

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @envoyproxy/maintainers I'm going to merge this, please LMK if you notice any weird behavior around API related code reviews.

Thanks @itayd for the awesome work.

@htuch htuch merged commit 2d0b449 into envoyproxy:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RepoKitteh-based selective CODEOWNERS enforcement on select subtrees

2 participants