ownerscheck demo - do not merge#7659
Closed
itayd wants to merge 5 commits intoenvoyproxy:masterfrom
itayd:patch-35
Closed
ownerscheck demo - do not merge#7659itayd wants to merge 5 commits intoenvoyproxy:masterfrom itayd:patch-35
itayd wants to merge 5 commits intoenvoyproxy:masterfrom
itayd:patch-35
Conversation
Contributor
Author
|
/rk-bless |
rktest2
approved these changes
Jul 20, 2019
htuch
approved these changes
Jul 22, 2019
htuch
pushed a commit
that referenced
this pull request
Jul 29, 2019
Per #7423: * When a PR contains changes to api/, @envoyproxy/api-shepherds are notified via a CC comment. * When a PR contains changes to api/udpa, @envoyproxy/udpa-wg is notified via a CC comment. * An additional GitHub check blocking merge is added that will only be marked as passing once an approval review is received from someone in @envoyproxy/api-shepherds. Risk Level: None. But if there is any issue, please revert. Testing: In test PRs under different users: #7659 Docs Changes: None. Release Notes: None Fixes #7423 Signed-off-by: Itay Donanhirsh <itay@bazoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.