coverage: ignore generated file precisely#7551
Merged
lizan merged 5 commits intoenvoyproxy:masterfrom Jul 12, 2019
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
@mattklein123 let's merge this first to fix #7474, https://248143-65214191-gh.circle-artifacts.com/0/coverage/coverage.html |
Merged
lizan
added a commit
that referenced
this pull request
Jul 13, 2019
Description: Fix regression of #7551 Risk Level: Testing: Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Regression in #6866.
k8-dbg/binis excluded to ignore generated files but virtual_includes are there too.Risk Level: Low
Testing: CI 🙏
Docs Changes:
Release Notes:
Fixes #7474