ci: update build image by lizan · Pull Request #6866 · envoyproxy/envoy

lizan · 2019-05-09T00:24:28Z

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

dio · 2019-05-14T13:21:20Z

@lizan is this (the mac build) hanging?

htuch · 2019-05-14T22:14:10Z

ci/run_clang_tidy.sh

 echo "build ${BAZEL_BUILD_OPTIONS}" >> .bazelrc

+# TODO(lizan): remove this once https://github.com/grailbio/bazel-compilation-database/issues/25 is fixed.
+echo "build --incompatible_disable_legacy_cc_provider=false" >> .bazelrc


FWIW, I only just read how this .bazelrc thing works today; it's pretty funky but I would much rather we switched to another build directory and created an ephemeral .bazelrc, e.g. what happens if you interrupt the local clang-tidy?

Well the trap EXIT worked, though we don't need this any more as upstream issue is resolved, and we don't have ci WORKSPACE anymore.

It worked providing you get the signal; if you nuke the Docker image or something, you don't get that.

htuch · 2019-05-14T22:15:12Z

ci/do_ci.sh

  # gcovr is a pain to run with `bazel run`, so package it up into a
  # relocatable and hermetic-ish .par file.
-  bazel build @com_github_gcovr_gcovr//:gcovr.par
+  bazel build --incompatible_remove_old_python_version_api=false @com_github_gcovr_gcovr//:gcovr.par


Is there a tracking bug to clean this one up? Hoping not to be too surprised at a Bazel point release.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

htuch · 2019-05-16T10:57:52Z

@lizan failing clang_tidy on CI.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

stale · 2019-05-24T08:26:51Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

hlopko · 2019-05-28T07:27:12Z

Hi @htuch @lizan, can we move forward with this cl? Is there a concrete problem or just lack of time and more urgent priorities?

Regarding --incompatible_disable_legacy_cc_provider, is seems grailbio/bazel-compilation-database#25 is fixed.

Regarding incompatible_remove_old_python_version_api and gcovr, what exactly is the issue? Can we just migrate for that flag? bazelbuild/bazel#7308 has decent migration instructions.

Thanks!

htuch · 2019-05-28T17:28:12Z

Happy to rubber stamp if we can get CI passing @hlopko @lizan

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

htuch · 2019-05-30T22:54:37Z

/retest

repokitteh-read-only · 2019-05-30T22:54:41Z

🔨 rebuilding ci/circleci: ipv6_tests (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6866 (comment) was created by @htuch.

see: more, trace.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan · 2019-05-31T17:51:28Z

/retest

repokitteh-read-only · 2019-05-31T17:51:33Z

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6866 (comment) was created by @lizan.

see: more, trace.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Description: Regression in #6866. k8-dbg/bin is excluded to ignore generated files but virtual_includes are there too. Risk Level: Low Testing: CI 🙏 Docs Changes: Release Notes: Fixes #7474 Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan added 2 commits May 9, 2019 00:24

ci: update build image

4d0b7e1

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

fix ci runs

1bf4b36

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan requested review from htuch and mattklein123 May 10, 2019 02:18

htuch previously approved these changes May 10, 2019

View reviewed changes

dio assigned htuch May 14, 2019

htuch reviewed May 14, 2019

View reviewed changes

htuch added the waiting:any label May 14, 2019

update clang-tidy run

07fbaed

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan dismissed htuch’s stale review via 07fbaed May 16, 2019 09:13

repokitteh-read-only bot removed the waiting:any label May 16, 2019

lizan added 2 commits May 17, 2019 07:35

update image to latest

bd9548e

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Merge remote-tracking branch 'upstream/master' into update_image

9cbfdda

htuch added the waiting label May 20, 2019

stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 24, 2019

lizan mentioned this pull request May 24, 2019

Update rules_foreign_cc version #7058

Closed

hlopko mentioned this pull request May 28, 2019

Bazel incompatible changes #6995

Closed

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 28, 2019

lizan added 2 commits May 30, 2019 00:04

bazel 0.26

131a4d0

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Merge remote-tracking branch 'upstream/master' into update_image

8212f87

repokitteh-read-only bot removed the waiting label May 30, 2019

lizan added 4 commits May 30, 2019 00:12

remove --incompatible_remove_old_python_version_api

a12f580

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

revert tidy script

a693087

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

--incompatible_depset_union=false

5bbacc3

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

0.26 compat

6346d1f

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

azure image

2905be7

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

htuch previously approved these changes May 30, 2019

View reviewed changes

test

320cadd

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan dismissed htuch’s stale review via 320cadd May 31, 2019 13:19

lizan mentioned this pull request May 31, 2019

Make protodoc.bzl compatible with Bazel 0.26+ #7120

Closed

fix coverage

94667d8

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan requested a review from htuch June 3, 2019 20:09

htuch approved these changes Jun 3, 2019

View reviewed changes

lizan merged commit f1cf265 into envoyproxy:master Jun 3, 2019

lizan deleted the update_image branch June 3, 2019 20:41

jmarantz mentioned this pull request Jun 7, 2019

stats_integration_test failing on Bazel CI #7196

Closed

htuch mentioned this pull request Jul 10, 2019

Coverage build no longer covers headers #7474

Closed

lizan mentioned this pull request Jul 11, 2019

coverage: ignore generated file precisely #7551

Merged

Conversation

lizan commented May 9, 2019

Uh oh!

dio commented May 14, 2019

Uh oh!

htuch May 14, 2019

Choose a reason for hiding this comment

Uh oh!

lizan May 16, 2019

Choose a reason for hiding this comment

Uh oh!

htuch May 16, 2019

Choose a reason for hiding this comment

Uh oh!

htuch May 14, 2019

Choose a reason for hiding this comment

Uh oh!

htuch commented May 16, 2019

Uh oh!

stale bot commented May 24, 2019

Uh oh!

hlopko commented May 28, 2019

Uh oh!

htuch commented May 28, 2019

Uh oh!

htuch commented May 30, 2019

Uh oh!

repokitteh-read-only bot commented May 30, 2019

Uh oh!

lizan commented May 31, 2019

Uh oh!

repokitteh-read-only bot commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants