Conversation
|
/cc @silentdai @htuch @PiotrSikora |
htuch
left a comment
There was a problem hiding this comment.
This looks like a great start. I think that validating warming/active and success/failure makes a lot of sense, even sticking with just Listener/RouteConfiguration we can get these properties.
/wait
There was a problem hiding this comment.
I'm genuinely curious how we can remove a route config today, I was having this conversation with @stevenzzzz and with SoTW updates, this doesn't seem possible? :)
There was a problem hiding this comment.
Can we use https://github.com/envoyproxy/envoy/blob/master/test/config/utility.h to avoid having custom bootstrap? I see that we do what you have here in ads_integration_test, so probably fine, but I was never a big fan of this.
There was a problem hiding this comment.
So, by not sending the route, Envoy will actually just continue to latch the last route it received. This is because RDS/EDS are a bit weird for SoTW updates vs. LDS/CDS. The latter delete resources when not mentioned in an update, the former don't. It's weird, I know, and something I'm actively thinking about as part of the next generation of the UDPA transport protocol.
|
@asraa the history here has a bunch of unrelated commits, can you maybe rebase and squash to clean things up? |
Moves AdsIntegrationTest to it's own file. I'd like to reuse the class for the xDS fuzzer (#7543), since the setup and utilities are the same. Risk Level: Low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com> remove bazel.output.txt Signed-off-by: Asra Ali <asraa@google.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This is a skeleton for an xDS fuzzer. The setup is very similar to ads_integration_test. The fuzzer tests against corpus files, which consist of sequences of xDS updates, currently just restricted to LDS/RDS (the test setup includes building a single cluster, and I might make route configurations only reference this cluster, or expand the possible xDS updates to include CDS actions).
Right now, the fuzzer just checks for crashes and verifies the number of lds updates is what we expect. I'd like the fuzzer to check:
If you have any feedback or things you'd like to see, please let me know. I'll update as I work.