test: separate AdsIntegrationTest to a library #7581
test: separate AdsIntegrationTest to a library #7581zuercher merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
zuercher
left a comment
There was a problem hiding this comment.
This looks good, I just want to see if we can trim down the dependencies for in the BUILD file to those actually used.
| "@envoy_api//envoy/api/v2:eds_cc", | ||
| "@envoy_api//envoy/api/v2:lds_cc", | ||
| "@envoy_api//envoy/api/v2:rds_cc", | ||
| "@envoy_api//envoy/service/discovery/v2:ads_cc", |
There was a problem hiding this comment.
Can we trim these dependencies (and the ones for ads_integration_lib) down to the set that each actually uses?
For example, it doesn't look like the the mocks are needed for either of these (you can probably even remove the #include directives) and it doesn't look like the library needs any of the API except ADS.
There was a problem hiding this comment.
Thank you! Removed unnecessary ones, but I think the library does need the API since the return values of build* are envoy::api::v2::Listener/Cluster, right? Technically they're included transitively through the config dump proto though. Not sure if guidelines are generally to explicitly include them.
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Moves AdsIntegrationTest to it's own file. I'd like to reuse the class for the xDS fuzzer (#7543), since the setup and utilities are the same.
Risk Level: Low
Signed-off-by: Asra Ali asraa@google.com