ssl: allow use of cipher strings.#751
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Apr 13, 2017
Merged
Conversation
Contributor
Author
|
While I think use of cipher strings is valid in general, the workaround for ChaCha20+Poly1305 cipher suites is temporary, because the draft variant is already removed from the next chromium-stable branch of BoringSSL. |
Member
Allow use of "ALL", "HIGH", "EECDH+AES128" and other cipher strings, which evaluate to more than one cipher suite. As a side-effect, this allows use of ChaCha20+Poly1305 cipher strings, which evaluate to two variants of the cipher suite (draft and RFC7539) in currently linked version of BoringSSL. While there, account for equal-preference groups when using BoringSSL. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
a019bc0 to
56a3d0b
Compare
mattklein123
approved these changes
Apr 13, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…751) Description: update envoy and include x-envoy-attempt-count in responses Risk Level: low, the new config option attaches a new header to responses. Testing: unit and integration tests in Envoy for the new feature. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…751) Description: update envoy and include x-envoy-attempt-count in responses Risk Level: low, the new config option attaches a new header to responses. Testing: unit and integration tests in Envoy for the new feature. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow use of "ALL", "HIGH", "EECDH+AES128" and other cipher strings,
which evaluate to more than one cipher suite.
As a side-effect, this allows use of ChaCha20+Poly1305 cipher strings,
which evaluate to two variants of the cipher suite (draft and RFC7539)
in currently linked version of BoringSSL.
While there, account for equal-preference groups when using BoringSSL.