bazel: gdb test wrapper script and docs.#749
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Apr 13, 2017
Merged
Conversation
Member
Author
tools/bazel-test-gdb
Outdated
| # | ||
| # tools/bazel-test-gdb //test/foo:bar --some_other --bazel_args | ||
|
|
||
| if [[ ! "$1" =~ //.*:.* ]] |
Member
There was a problem hiding this comment.
Can we support a repository prefix here also like @envoy//test/foo:bar ?
tools/bazel-test-gdb
Outdated
| trap cleanup EXIT | ||
|
|
||
| bazel test "$@" --strategy=TestRunner=standalone --cache_test_results=no \ | ||
| --test_output=summary --run_under="$PWD/tools/gen_gdb_wrapper_script.py ${GDB_RUNNER}" |
Member
There was a problem hiding this comment.
I will likely run this from a parent directory (same for istio). Instead of $PWD can we pull out script directory and use that?
tools/gen_gdb_wrapper_script.py
Outdated
| os.environ[k] = v | ||
|
|
||
| os.chdir('${working_dir}') | ||
| os.system('gdb ${test_path}') |
Member
There was a problem hiding this comment.
Is test_path always a script (single arg)? Do we every need gdb --args ?
Member
Author
|
Fixed the above and verified from envoy-consumer. |
mattklein123
approved these changes
Apr 13, 2017
mattklein123
added a commit
that referenced
this pull request
Jun 9, 2022
Signed-off-by: Matt Klein <mklein@lyft.com>
mattklein123
pushed a commit
that referenced
this pull request
Jun 9, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com>
mattklein123
pushed a commit
that referenced
this pull request
Jun 9, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com>
mattklein123
pushed a commit
that referenced
this pull request
Jun 9, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com>
mattklein123
pushed a commit
that referenced
this pull request
Jun 9, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com>
LukeShu
pushed a commit
to gravitee-io/envoy
that referenced
this pull request
Jun 9, 2022
commit 34f89c5a567694d8dda4d9c7f4ddfa76124932e7
Author: Matt Klein <mklein@lyft.com>
Date: Thu May 19 16:25:24 2022 +0000
grpc: fix previous patch
Once approved this will be squashed into the previous commit.
Signed-off-by: Matt Klein <mklein@lyft.com>
commit 58c8e2eb1bcdfa1e9a4f2829c49cbf98085d48c0
Author: Pradeep Rao <pcrao@google.com>
Date: Thu May 12 16:17:55 2022 +0000
healthcheck: fix grpc inline removal crashes (envoyproxy#749)
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
GregHanson
pushed a commit
to istio/envoy
that referenced
this pull request
Jun 9, 2022
commit 8a9cc439ca15c0ca8905bf0c3f7a2ff042da1171
Author: Matt Klein <mklein@lyft.com>
Date: Thu May 19 16:25:24 2022 +0000
grpc: fix previous patch
Once approved this will be squashed into the previous commit.
Signed-off-by: Matt Klein <mklein@lyft.com>
commit 2e911a1d6da10f3d93d6349884cb345955793245
Author: Pradeep Rao <pcrao@google.com>
Date: Thu May 12 16:05:33 2022 +0000
healthcheck: fix grpc inline removal crashes (envoyproxy#749)
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
GregHanson
pushed a commit
to istio/envoy
that referenced
this pull request
Jun 9, 2022
commit 0eb6bda4cf0eb338b3144c1df70b39b6a6eaf303
Author: Matt Klein <mklein@lyft.com>
Date: Thu May 19 16:25:24 2022 +0000
grpc: fix previous patch
Once approved this will be squashed into the previous commit.
Signed-off-by: Matt Klein <mklein@lyft.com>
commit 4d30a0ecd5b11c78e7d532ab4f20703b733edf24
Author: Pradeep Rao <pcrao@google.com>
Date: Thu May 12 15:41:10 2022 +0000
healthcheck: fix grpc inline removal crashes (envoyproxy#749)
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
GregHanson
pushed a commit
to istio/envoy
that referenced
this pull request
Jun 9, 2022
commit a5872b87cdf9853294ac4d5a9a22a633d812bd80
Author: Matt Klein <mklein@lyft.com>
Date: Thu May 19 16:25:24 2022 +0000
grpc: fix previous patch
Once approved this will be squashed into the previous commit.
Signed-off-by: Matt Klein <mklein@lyft.com>
commit 4b24c6dc5809447fb79cec18ce0235dc9cbdb620
Author: Pradeep Rao <pcrao@google.com>
Date: Thu May 12 15:37:46 2022 +0000
healthcheck: fix grpc inline removal crashes (envoyproxy#749)
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
mattklein123
pushed a commit
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
nfuden
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Jun 13, 2022
commit 34f89c5a567694d8dda4d9c7f4ddfa76124932e7
Author: Matt Klein <mklein@lyft.com>
Date: Thu May 19 16:25:24 2022 +0000
grpc: fix previous patch
Once approved this will be squashed into the previous commit.
Signed-off-by: Matt Klein <mklein@lyft.com>
commit 58c8e2eb1bcdfa1e9a4f2829c49cbf98085d48c0
Author: Pradeep Rao <pcrao@google.com>
Date: Thu May 12 16:17:55 2022 +0000
healthcheck: fix grpc inline removal crashes (envoyproxy#749)
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
tyxia
referenced
this pull request
in tyxia/envoy
Jun 14, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Tianyu Xia <tyxia@google.com>
mattklein123
pushed a commit
that referenced
this pull request
Jun 15, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 16, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
mattklein123
pushed a commit
that referenced
this pull request
Jun 17, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: disable until #748 is fixed. Risk Level: low given stats are being flushed every 5 secs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: disable until #748 is fixed. Risk Level: low given stats are being flushed every 5 secs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.