build: use static config_impl_test to generate corpus#6725
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom May 6, 2019
Merged
build: use static config_impl_test to generate corpus#6725htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
suggested changes
Apr 26, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM, just one quick comment.
/wait-any
| ], | ||
| ) | ||
|
|
||
| # envoy_cc_test_binary is generating mostly static binary regardless of config |
Member
There was a problem hiding this comment.
Is this always going to be true? Is there a way to make this more robust?
Member
Author
There was a problem hiding this comment.
Yes, envoy_cc_test_binary employs envoy_cc_binary which is always linkstatic=1.
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
htuch
approved these changes
May 6, 2019
lizan
pushed a commit
that referenced
this pull request
May 13, 2019
#6871) Description: The build target `//test/common/router:config_impl_test_static` was relying upon the `_lib` target that is created by the `envoy_cc_test` in envoy_build_system.bzl. This target should not be relied upon since it is an implementation detail of the Envoy build system rather than a public build target that we want to allow dependencies upon. This PR restricts the visibility of these synthetic targets to only the code coverage tools and renames them to end with `_lib_INTERNAL_ONLY` instead. See #6725 for where we started using these synthetic targets in our `BUILD` files. This PR also hides the `envoy_cc_test_infrastructure_library` build macro by renaming it to `_envoy_cc_test_infrastructure_library` as per https://docs.bazel.build/versions/master/build-ref.html#load. This macro was not being used outside of envoy_build_system.bzl. Note this does not break coverage builds since coverage pulls in the synthetic targets via the `coverage_test_lib` tag, see [generated_coverage_BUILD.txt](https://github.com/envoyproxy/envoy/files/3163463/generated_coverage_BUILD.txt) for the generated coverage `BUILD` file. Risk Level: Low Testing: Ran `bazel test //test/common/...`. and ran `test/run_envoy_bazel_coverage.sh`. Docs Changes: N/A Release Notes: N/A Signed-off-by: Frank Fort <ffort@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
As we use
srcsto specify the tools to avoid host/target confusion, the src need to be static otherwise dynamic libraries cannot be loaded after #6704 in strict sandbox.Risk Level: Low
Testing: test only
Docs Changes: N/A
Release Notes: N/A