build: dynamic link tests in ASAN#6704
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Apr 25, 2019
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
4f93620 to
deac8f0
Compare
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
@htuch This is good to go. It brings disk space required for ASAN down to ~40GB. |
htuch
approved these changes
Apr 25, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Fantastic, I had start to play around with this but stopped when I hit some test issues. Looks like you figured them out. Thanks.
htuch
pushed a commit
that referenced
this pull request
May 6, 2019
As we use srcs to specify the tools to avoid host/target confusion, the src need to be static otherwise dynamic libraries cannot be loaded after #6704 in strict sandbox. Risk Level: Low Testing: test only Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Dynamic link tests in ASAN to save disk space. Partially addresses #1407.
Risk Level: Low (ASAN only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A