mysql_filter: add a warning about compatibility#6234
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Mar 11, 2019
Merged
mysql_filter: add a warning about compatibility#6234mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
This adds a warning to the MySQL filter docs regarding compatibility issues with the filter. Signed-off-by: Venil Noronha <veniln@vmware.com>
mattklein123
requested changes
Mar 10, 2019
|
|
||
| .. warning:: | ||
|
|
||
| The mysql_proxy filter was tested with MySQL v5.5. The filter may not work |
Member
There was a problem hiding this comment.
hmm, I'm quite sure we had verified this with mysql 8 at some point @venilnoronha how can I open ticket ? will work on fixing this.
Member
Author
There was a problem hiding this comment.
@dkalani can you verify it with 8.x and update here? If it does work, we can update this message. If not, we can create an issue to track it and fix it.
Member
There was a problem hiding this comment.
when we tried with upstream mysql (8 or 9), it didn't work properly. Thats why I asked venil to update this.
Signed-off-by: Venil Noronha <veniln@vmware.com>
rshriram
approved these changes
Mar 10, 2019
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Mar 11, 2019
* master: token bucket: several fixes (envoyproxy#6235) config: move logging of full response to trace logging (envoyproxy#6226) mysql_filter: add a warning about compatibility (envoyproxy#6234) upstream: add transport socket failure reason to stream info and log (envoyproxy#6018) IoHandle readv and writev (envoyproxy#6037) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This adds a warning to the MySQL filter docs regarding compatibility issues with the filter.
Risk Level: Low
Testing: N/A
Docs Changes: Updates the MySQL filter docs
Release Notes: N/A