config: move logging of full response to trace logging#6226
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Mar 11, 2019
Merged
config: move logging of full response to trace logging#6226htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
With large response bodies, this tends to seize up the proccess due to log volume, making debug logging not very useful. This drops logging the entire update to trace. Signed-off-by: Snow Pettersen <snowp@squareup.com>
venilnoronha
reviewed
Mar 9, 2019
Member
venilnoronha
left a comment
There was a problem hiding this comment.
I feel that the log needs to be more specific.
| resources.size(), RepeatedPtrUtil::debugString(typed_resources)); | ||
| ENVOY_LOG(debug, "gRPC config for {} accepted with {} resources with version {}", type_url_, | ||
| resources.size(), version_info); | ||
| ENVOY_LOG(trace, "resources: {}", RepeatedPtrUtil::debugString(typed_resources)); |
Member
There was a problem hiding this comment.
Since multiple threads can be logging at the same time, I'd actually have a more specific line when printing out resources in the trace. Something like below:
ENVOY_LOG(trace, "_gRPC config accepted with resources: {}_", RepeatedPtrUtil::debugString(typed_resources));
Member
There was a problem hiding this comment.
I think demuxing multiple threads is a consumer issue, for example I have a log viewer that can colorize based on TID. So, no need to force it into a single statement.
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Mar 11, 2019
* master: token bucket: several fixes (envoyproxy#6235) config: move logging of full response to trace logging (envoyproxy#6226) mysql_filter: add a warning about compatibility (envoyproxy#6234) upstream: add transport socket failure reason to stream info and log (envoyproxy#6018) IoHandle readv and writev (envoyproxy#6037) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With large response bodies, this tends to seize up the process due to
log volume, making debug logging not very useful. This drops logging the
entire update to trace.
Also includes the resource version in the debug log line.
Signed-off-by: Snow Pettersen snowp@squareup.com
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a