config: add GrpcStream: gRPC mechanisms pulled out of GrpcMux#5681
Merged
htuch merged 14 commits intoenvoyproxy:masterfrom Jan 24, 2019
Merged
config: add GrpcStream: gRPC mechanisms pulled out of GrpcMux#5681htuch merged 14 commits intoenvoyproxy:masterfrom
htuch merged 14 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
jmarantz
reviewed
Jan 22, 2019
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
htuch
suggested changes
Jan 23, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Yep, this looks great, just some procedural comments mostly.
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Contributor
Author
|
I just realized that most of the names in this directory leave their association with xDS implicit, based on the directory they're living in. Would DiscoveryGrpcStream then make more sense as GrpcStream, despite sounding overly generic at first glance? |
Member
|
Since it's in the |
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
htuch
reviewed
Jan 23, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Other than a nit, LGTM, thanks.
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Contributor
Author
|
Forgot to tag this as part of work on #4991. |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 31, 2019
…roxy#5681) Refactor necessary for envoyproxy#5466 to avoid completely duplicating this logic. Risk Level: low Testing: existing tests Signed-off-by: Fred Douglas <fredlas@google.com> Signed-off-by: Fred Douglas <43351173+fredlas@users.noreply.github.com>
fredlas
added a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…roxy#5681) Refactor necessary for envoyproxy#5466 to avoid completely duplicating this logic. Risk Level: low Testing: existing tests Signed-off-by: Fred Douglas <fredlas@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Refactor necessary for #5466 to avoid completely duplicating this logic.
Risk Level: low
Testing: existing tests