Skip to content

Fix the BoringSSL link in the requirements section of the docs.#470

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
brian-pane:docfix_boringssl
Feb 12, 2017
Merged

Fix the BoringSSL link in the requirements section of the docs.#470
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
brian-pane:docfix_boringssl

Conversation

@brian-pane
Copy link
Copy Markdown
Contributor

No description provided.

@mattklein123 mattklein123 merged commit b8d94f7 into envoyproxy:master Feb 12, 2017
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
* Shrink and better document the debug image

before: 722MB
after: 236MB
(Not counting envoy itself)

Fixes envoyproxy#423

Needs istio/old_pilot_repo#1202 to fully work

```release-note
Reduce proxy debug image by 2/3rd (486Mb) yet as functional
```

* Alignement fix
lizan pushed a commit to lizan/envoy that referenced this pull request Apr 24, 2020
Use the proxy-wasm-cpp-sdk and basel to build test_cpp.wasm.
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021
jpsim pushed a commit that referenced this pull request Nov 28, 2022
* Work around BoringSSL bitcode linker warning

When linking envoy-mobile to an iOS app that ships with bitcode, you get
these warnings from the linker:

```
ld: warning: Linker asked to preserve internal global: 'sk_CRYPTO_BUFFER_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
```

I have submitted an upstream patch to fix this
https://boringssl-review.googlesource.com/c/boringssl/+/37804 in the
meantime I've applied that patch here.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Reverting #470 which is a patch to boringssl
https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Part of #23758
Fixes #471

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
* Work around BoringSSL bitcode linker warning

When linking envoy-mobile to an iOS app that ships with bitcode, you get
these warnings from the linker:

```
ld: warning: Linker asked to preserve internal global: 'sk_CRYPTO_BUFFER_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func'
```

I have submitted an upstream patch to fix this
https://boringssl-review.googlesource.com/c/boringssl/+/37804 in the
meantime I've applied that patch here.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Reverting #470 which is a patch to boringssl
https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Part of #23758
Fixes #471

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
**Commit Message**

This changes the stat collection behavior so that token latency metrics
are only recorded on stream=true requests. This was brought up in an
offline discussion and otherwise the metrics doesn't make sense.

**Related Issues/PRs (if applicable)**

#459

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants