-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
Description
Envoy's custom Optional is anemic compared to absl (https://github.com/abseil/abseil-cpp/blob/master/absl/types/optional.h) and folly (https://github.com/facebook/folly/blob/master/folly/Optional.h)
For instance, envoy Optional doesn't have move ctors and doesn't do some finger-saving type inference.
Replace with one of the above, presumably absl's since that's already an envoy dep.
AFAICT the big-picture difference between absl's and folly's is that absl's is a drop-in replacement for std::optional (C++17). Folly's has more bells and whistles but given that envoy has been getting away with the current impl, absl is a better call.
Reactions are currently unavailable