deps: delete curl and extensions/grpc_creds/aws_iam by ggreenway · Pull Request #39138 · envoyproxy/envoy

ggreenway · 2025-04-16T03:52:59Z

A notice of deletion for the aws_iam extension was sent out two releases ago. It was the last use of curl, so that dependency can now be fully removed.
Risk Level: Medium
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Fixes envoyproxy#37621 Fixes envoyproxy#11816 Signed-off-by: Greg Greenway <ggreenway@apple.com>

repokitteh-read-only · 2025-04-16T03:53:09Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #39138 was opened by ggreenway.

see: more, trace.

Signed-off-by: Greg Greenway <ggreenway@apple.com>

repokitteh-read-only · 2025-04-16T03:56:15Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #39138 was synchronize by ggreenway.

see: more, trace.

ggreenway · 2025-04-16T03:58:24Z

cc @nbaws

source/extensions/common/aws/iam_roles_anywhere_signer_base_impl.cc

source/extensions/common/aws/iam_roles_anywhere_signer_base_impl.h

source/extensions/common/aws/BUILD

nbaws · 2025-04-16T05:51:51Z

source/extensions/common/aws/metadata_credentials_provider_base.h

-  MetadataCredentialsProviderBase(Api::Api& api, ServerFactoryContextOptRef context,
+  MetadataCredentialsProviderBase(Api::Api& api,
+                                  Server::Configuration::ServerFactoryContext& context,
                                  AwsClusterManagerOptRef aws_cluster_manager,


I believe we're able to get rid of the AwsClusterManagerOptRef (turn it into a standard ref) in this scenario as well, but I will pick this up in a later patch

nbaws · 2025-04-16T05:52:22Z

wow.. i was really looking forward to doing that myself :) thanks @ggreenway

abeyad

/lgtm api

I believe the missing coverage has never had tests, but this PR deleted some code in these directories which lowered the covered percent. Signed-off-by: Greg Greenway <ggreenway@apple.com>

repokitteh-read-only · 2025-04-16T22:05:37Z

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #39138 was synchronize by ggreenway.

see: more, trace.

Signed-off-by: Greg Greenway <ggreenway@apple.com>

RyanTheOptimist

coverage lgtm

phlax

/lgtm deps

jmarantz

a tour-de-force of a cleanup. Thanks!

Fixes envoyproxy#37621 Fixes envoyproxy#11816 A notice of deletion for the aws_iam extension was sent out two releases ago. It was the last use of curl, so that dependency can now be fully removed. Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>

Fixes envoyproxy#37621 Fixes envoyproxy#11816 A notice of deletion for the aws_iam extension was sent out two releases ago. It was the last use of curl, so that dependency can now be fully removed. Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: Jacob Lisi <jtlisi@google.com>

…ing - part 3 (#39521) Commit Message: aws: Implementation of IAM Roles anywhere support in aws request signing - part 3 Additional Description: Part 3 of 3 patches to implement IAM Roles anywhere capability. Integrates the previously added components with the credential chain and unhides the IAM Roles Anywhere credential provider definition in the API. Also reverts the coverage limit created in #39138 back to default coverage requirements. Design brief: #37440 Part 2 of this patch: #39025 (https://docs.aws.amazon.com/rolesanywhere/latest/userguide/introduction.html) Risk Level: Low - extension only changes Testing: Unit Docs Changes: N/A Release Notes: N/A Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Nigel Brittain <nbaws@amazon.com>

…ing - part 3 (#39521) Commit Message: aws: Implementation of IAM Roles anywhere support in aws request signing - part 3 Additional Description: Part 3 of 3 patches to implement IAM Roles anywhere capability. Integrates the previously added components with the credential chain and unhides the IAM Roles Anywhere credential provider definition in the API. Also reverts the coverage limit created in envoyproxy/envoy#39138 back to default coverage requirements. Design brief: envoyproxy/envoy#37440 Part 2 of this patch: envoyproxy/envoy#39025 (https://docs.aws.amazon.com/rolesanywhere/latest/userguide/introduction.html) Risk Level: Low - extension only changes Testing: Unit Docs Changes: N/A Release Notes: N/A Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Nigel Brittain <nbaws@amazon.com> Mirrored from https://github.com/envoyproxy/envoy @ 1ed3da6fe3c72d15008d8abb110573db3b3e5091

deps: delete curl and extensions/grpc_creds/aws_iam

4e93bba

Fixes envoyproxy#37621 Fixes envoyproxy#11816 Signed-off-by: Greg Greenway <ggreenway@apple.com>

ggreenway requested a review from mattklein123 as a code owner April 16, 2025 03:53

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 16, 2025

repokitteh-read-only bot assigned phlax Apr 16, 2025

ggreenway added 2 commits April 15, 2025 20:54

changelog

4a4ef87

Signed-off-by: Greg Greenway <ggreenway@apple.com>

config

bd7b3fd

Signed-off-by: Greg Greenway <ggreenway@apple.com>

repokitteh-read-only bot added the api label Apr 16, 2025

repokitteh-read-only bot assigned abeyad Apr 16, 2025

nbaws reviewed Apr 16, 2025

View reviewed changes

source/extensions/common/aws/iam_roles_anywhere_signer_base_impl.cc Show resolved Hide resolved

nbaws reviewed Apr 16, 2025

View reviewed changes

source/extensions/common/aws/iam_roles_anywhere_signer_base_impl.h Show resolved Hide resolved

nbaws reviewed Apr 16, 2025

View reviewed changes

source/extensions/common/aws/BUILD Show resolved Hide resolved

nbaws reviewed Apr 16, 2025

View reviewed changes

abeyad previously approved these changes Apr 16, 2025

View reviewed changes

repokitteh-read-only bot removed the api label Apr 16, 2025

fixes

ce92f43

I believe the missing coverage has never had tests, but this PR deleted some code in these directories which lowered the covered percent. Signed-off-by: Greg Greenway <ggreenway@apple.com>

ggreenway dismissed abeyad’s stale review via ce92f43 April 16, 2025 22:05

repokitteh-read-only bot added the api label Apr 16, 2025

repokitteh-read-only bot assigned RyanTheOptimist Apr 16, 2025

ggreenway added 2 commits April 16, 2025 16:01

delete docs reference

18ee74b

Signed-off-by: Greg Greenway <ggreenway@apple.com>

revert accidental delete of needed files

769cca3

Signed-off-by: Greg Greenway <ggreenway@apple.com>

RyanTheOptimist reviewed Apr 18, 2025

View reviewed changes

phlax approved these changes Apr 18, 2025

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 18, 2025

ggreenway removed the api label Apr 18, 2025

jmarantz self-assigned this Apr 21, 2025

jmarantz approved these changes Apr 21, 2025

View reviewed changes

repokitteh-read-only bot added the api label Apr 21, 2025

ggreenway merged commit 06f25d8 into envoyproxy:main Apr 21, 2025
25 of 26 checks passed

This was referenced Apr 22, 2025

sync envoy istio-testing/proxy#1

Closed

Sync envoy istio/proxy#6257

Merged

nbaws mentioned this pull request May 17, 2025

aws: Implementation of IAM Roles anywhere support in aws request signing - part 3 #39521

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: delete curl and extensions/grpc_creds/aws_iam#39138

deps: delete curl and extensions/grpc_creds/aws_iam#39138
ggreenway merged 6 commits intoenvoyproxy:mainfrom
ggreenway:delete-curl

ggreenway commented Apr 16, 2025

Uh oh!

repokitteh-read-only bot commented Apr 16, 2025

Uh oh!

repokitteh-read-only bot commented Apr 16, 2025

Uh oh!

ggreenway commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nbaws Apr 16, 2025

Uh oh!

nbaws commented Apr 16, 2025

Uh oh!

abeyad left a comment

Uh oh!

repokitteh-read-only bot commented Apr 16, 2025

Uh oh!

RyanTheOptimist left a comment

Uh oh!

phlax left a comment

Uh oh!

jmarantz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ggreenway commented Apr 16, 2025

Uh oh!

repokitteh-read-only bot commented Apr 16, 2025

Uh oh!

repokitteh-read-only bot commented Apr 16, 2025

Uh oh!

ggreenway commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nbaws Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

nbaws commented Apr 16, 2025

Uh oh!

abeyad left a comment

Choose a reason for hiding this comment

Uh oh!

repokitteh-read-only bot commented Apr 16, 2025

Uh oh!

RyanTheOptimist left a comment

Choose a reason for hiding this comment

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

jmarantz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants