Skip to content

aws: Implementation of IAM Roles anywhere support in aws request signing - part 3#39521

Merged
mattklein123 merged 147 commits intoenvoyproxy:mainfrom
nbaws:roles_anywhere_3
Jun 17, 2025
Merged

aws: Implementation of IAM Roles anywhere support in aws request signing - part 3#39521
mattklein123 merged 147 commits intoenvoyproxy:mainfrom
nbaws:roles_anywhere_3

Conversation

@nbaws
Copy link
Copy Markdown
Contributor

@nbaws nbaws commented May 17, 2025

Commit Message: aws: Implementation of IAM Roles anywhere support in aws request signing - part 3
Additional Description:
Part 3 of 3 patches to implement IAM Roles anywhere capability. Integrates the previously added components with the credential chain and unhides the IAM Roles Anywhere credential provider definition in the API.

Also reverts the coverage limit created in #39138 back to default coverage requirements.

Design brief: #37440
Part 2 of this patch: #39025

(https://docs.aws.amazon.com/rolesanywhere/latest/userguide/introduction.html)

Risk Level: Low - extension only changes
Testing: Unit
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

nbaws added 30 commits March 1, 2025 00:49
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
nbaws added 2 commits May 29, 2025 00:14
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
@nbaws
Copy link
Copy Markdown
Contributor Author

nbaws commented May 29, 2025

/retest

Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Copy link
Copy Markdown
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@repokitteh-read-only repokitteh-read-only bot removed the api label Jun 4, 2025
Copy link
Copy Markdown

@niax niax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this; it looks good to me.

Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
@nbaws
Copy link
Copy Markdown
Contributor Author

nbaws commented Jun 15, 2025

@mattklein123 aws review complete on this one.

@mattklein123
Copy link
Copy Markdown
Member

Sorry needs a main merge.

/wait

Signed-off-by: Nigel Brittain <nbaws@amazon.com>
@nbaws
Copy link
Copy Markdown
Contributor Author

nbaws commented Jun 17, 2025

@mattklein123 merged - ty

mattklein123
mattklein123 previously approved these changes Jun 17, 2025
@mattklein123 mattklein123 enabled auto-merge (squash) June 17, 2025 02:30
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
auto-merge was automatically disabled June 17, 2025 04:25

Head branch was pushed to by a user without write access

Signed-off-by: Nigel Brittain <nbaws@amazon.com>
@nbaws
Copy link
Copy Markdown
Contributor Author

nbaws commented Jun 17, 2025

@mattklein123 dismissed your approval apologies - i had to add some extra coverage.

@mattklein123 mattklein123 merged commit 1ed3da6 into envoyproxy:main Jun 17, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants