local info: refactor information about the local env#332
Merged
mattklein123 merged 3 commits intomasterfrom Jan 6, 2017
Merged
local info: refactor information about the local env#332mattklein123 merged 3 commits intomasterfrom
mattklein123 merged 3 commits intomasterfrom
Conversation
This has been bothering me for a while. We are copying things like local zone, local cluster, etc. all over the place. It's also likely that we will add more things in the future. This introduces a LocalInfo abstract class which holds such information. The change is large by number of lines but it's simple.
Member
Author
|
@lyft/network-team |
wgallagher
reviewed
Jan 6, 2017
| */ | ||
| virtual uint64_t restartEpoch() PURE; | ||
|
|
||
| /** |
| virtual ~LocalInfo() {} | ||
|
|
||
| /** | ||
| * Human readable network address. |
Member
There was a problem hiding this comment.
nit: can you put also example for this. Human readable network address, e.g., ...
wgallagher
approved these changes
Jan 6, 2017
Member
|
+1 |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Previously, square brackets without being followed by () was also rejected. This fixes the regex and allows it. **Related Issues/PRs (if applicable)** Follow up on #322 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been bothering me for a while. We are copying things like local
zone, local cluster, etc. all over the place. It's also likely that we will
add more things in the future. This introduces a LocalInfo abstract class
which holds such information.
The change is large by number of lines but it's simple.