outlier: handle cross thread destroy#322
Merged
mattklein123 merged 1 commit intomasterfrom Jan 5, 2017
Merged
Conversation
This is a lot complicated, see the comment in the commit. Needed for dynamic cluster removal.
Member
Author
|
@lyft/network-team |
ccaraman
approved these changes
Jan 5, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…roxy#322) * Updated the latest commit id of cloudendpoints/service-control-client-cxx * Use the original error description from the quota control API * fixed code formatting * Fixed test cases * Add ConfigManager to ApiManager * Revert "Add ConfigManager to ApiManager" This reverts commit 26fb7f0eda5ba92e16adc5e0ca3a048e8880e142.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
yxue
pushed a commit
to yxue/envoy
that referenced
this pull request
Dec 3, 2019
Signed-off-by: Yaroslav Skopets <y.skopets@gmail.com>
liverbirdkte
referenced
this pull request
in liverbirdkte/envoy
Oct 18, 2022
Fix issue of incorrectly copy cert subject to mimic cert. Use cert expiration time when expiration_time config is absent. Signed-off-by: LeiZhang <lei.a.zhang@intel.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This PR inlines certificates for trusted certificate authorities into the config template and adds subject alt name verification to the base cluster. The certificate bundle is the same as that presented in MacOS 10.14.6 Risk Level: High Testing: Simulator Fixes #322 Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This PR inlines certificates for trusted certificate authorities into the config template and adds subject alt name verification to the base cluster. The certificate bundle is the same as that presented in MacOS 10.14.6 Risk Level: High Testing: Simulator Fixes #322 Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Use regex to check. **Related Issues/PRs (if applicable)** Fixes #267 --------- Signed-off-by: Loong <long0dai@foxmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Previously, square brackets without being followed by () was also rejected. This fixes the regex and allows it. **Related Issues/PRs (if applicable)** Follow up on #322 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little complicated, see the comment in the commit. Needed for
dynamic cluster removal.