Fix circular dependency between matchers and stats, grpc#32587
Merged
ggreenway merged 4 commits intoenvoyproxy:mainfrom Feb 29, 2024
Merged
Fix circular dependency between matchers and stats, grpc#32587ggreenway merged 4 commits intoenvoyproxy:mainfrom
ggreenway merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
mattklein123
approved these changes
Feb 27, 2024
Member
Author
|
/retest |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Mar 5, 2024
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update to .bazelrc and tools/gen_compilation_database.py to envoyproxy/envoy#32585 - Update source/client/process_impl.cc to accommodate refactor in envoyproxy/envoy#32587 - Update tools/code_format/config.yaml for changes in envoyproxy/envoy#32625 and envoyproxy/envoy#32252 - Update python dependencies - Ensure ostream_formatter definitions are before usage to prevent "explicit specialization of X after instantiation" errors Signed-off-by: Tom Zhang <4367421+tomjzzhang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Break circular dependency within bazel rules that was created when adding extension point to StringMatcher
Additional Description: This is part of #32586, pulled into a separate PR for easy review
Risk Level: Low
Testing:
Docs Changes: None
Release Notes: None
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]