wasm: moving a utility to wasm/common#32252
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Feb 27, 2024
Merged
Conversation
d109016 to
4503b93
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
kyessenov
previously approved these changes
Feb 21, 2024
Contributor
kyessenov
left a comment
There was a problem hiding this comment.
Good idea, considering URL fetch by Wasm that uses this code is not recommended.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
auto-merge was automatically disabled
February 26, 2024 18:56
Pull Request is not mergeable
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Mar 5, 2024
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update to .bazelrc and tools/gen_compilation_database.py to envoyproxy/envoy#32585 - Update source/client/process_impl.cc to accommodate refactor in envoyproxy/envoy#32587 - Update tools/code_format/config.yaml for changes in envoyproxy/envoy#32625 and envoyproxy/envoy#32252 - Update python dependencies - Ensure ostream_formatter definitions are before usage to prevent "explicit specialization of X after instantiation" errors Signed-off-by: Tom Zhang <4367421+tomjzzhang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a general utility but in 4 years it's still only used by wasm (at least downstream?)
Risk Level: low: code move
Testing: n/a
Docs Changes: n/a
Release Notes: n/a