Merged
Conversation
Member
Author
|
@lyft/network-team |
| void EventLoggerImpl::logEject(HostDescriptionPtr host, EjectionType type) { | ||
| // TODO: Log friendly host name (e.g., instance ID or DNS name). | ||
| // clang-format off | ||
| static const std::string json = |
Member
There was a problem hiding this comment.
minor, but having something like
static const std::string json = R"EOF(
{
}
)EOF";
easier to read, but up to you.
Member
Author
There was a problem hiding this comment.
That includes newlines which need to be trimmed. I didn't want to bother with that.
ccaraman
approved these changes
Dec 5, 2016
Member
|
+1 |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
lambdai
pushed a commit
to lambdai/envoy-dai
that referenced
this pull request
Oct 16, 2020
…oxy#273) Signed-off-by: Kuat Yessenov <kuat@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Adds Swift interfaces for responses within Envoy. These should be at parity with the interfaces being added for Kotlin in envoyproxy/envoy-mobile#265. Replaces envoyproxy/envoy-mobile#261. Resolves envoyproxy/envoy-mobile#118. Also resolves envoyproxy/envoy-mobile#247. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Adds Swift interfaces for responses within Envoy. These should be at parity with the interfaces being added for Kotlin in envoyproxy/envoy-mobile#265. Replaces envoyproxy/envoy-mobile#261. Resolves envoyproxy/envoy-mobile#118. Also resolves envoyproxy/envoy-mobile#247. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This introduces a new GitHub Actions workflow to check the length of issue titles and provide feedback if they exceed a specified limit. **Related Issues/PRs (if applicable)** Fixes envoyproxy/ai-gateway#270 --------- Signed-off-by: soma00333 <soma03432303@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.