wasm: support list lookup in get_property#13483
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Oct 12, 2020
Merged
wasm: support list lookup in get_property#13483mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Comment on lines
+582
to
+594
| std::string list_value; | ||
| if (!getValue({"node", "metadata", "wasm_node_list_key", "0"}, &list_value)) { | ||
| logDebug("missing node metadata list value"); | ||
| } | ||
| if (list_value != "wasm_node_get_value") { | ||
| logWarn("unexpected list value: " + list_value); | ||
| } | ||
| if (getValue({"node", "metadata", "wasm_node_list_key", "bad_key"}, &list_value)) { | ||
| logDebug("unexpected list value for a bad_key"); | ||
| } | ||
| if (getValue({"node", "metadata", "wasm_node_list_key", "1"}, &list_value)) { | ||
| logDebug("unexpected list value outside the range"); | ||
| } |
Member
There was a problem hiding this comment.
Does the test fail if the debug statements fail? Does the test actually verify any values? If not please make this test more robust so it actually checks things. Thank you!
/wait
Contributor
Author
There was a problem hiding this comment.
This is just how these tests work. All log statements must have a mock expectation. Since I didn't add those expectations, the log calls are not hit.
Member
There was a problem hiding this comment.
Ah OK, sounds good, thanks.
kyessenov
added a commit
to istio/envoy
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Oct 13, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Commit Message: Add traversal by decimal index in a list
Additional Description:
Risk Level: low
Testing: unit
Docs Changes: none
Release Notes: none