stats: remove use and definition of deprecated functions#25136
Merged
jmarantz merged 1 commit intoenvoyproxy:mainfrom Jan 25, 2023
Merged
stats: remove use and definition of deprecated functions#25136jmarantz merged 1 commit intoenvoyproxy:mainfrom
jmarantz merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
RyanTheOptimist
approved these changes
Jan 25, 2023
RyanTheOptimist
added a commit
to RyanTheOptimist/envoy
that referenced
this pull request
Jan 25, 2023
…oyproxy#25136)" Breaks Envoy Mobile builds. This reverts commit e816122. Signed-off-by: Ryan Hamilton <rch@google.com>
VishalDamgude
pushed a commit
to freshworks-oss/envoy
that referenced
this pull request
Feb 2, 2023
…25136) Commit Message: Removes Stats::ScopePtr definition as well as the cast operator from Stats::Store to Stats::Scope. Additional Description: Risk Level: medium -- other PRs may be adding use of this; but the cleanup should be easy if necessary. There may also be out-of-repo deps which I mostly tried to clean up where I could find them. Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Fixes: envoyproxy#20911 Fixes: envoyproxy#24007 Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Removes Stats::ScopePtr definition as well as the cast operator from Stats::Store to Stats::Scope.
Additional Description:
Risk Level: medium -- other PRs may be adding use of this; but the cleanup should be easy if necessary. There may also be out-of-repo deps which I mostly tried to clean up where I could find them.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes: #20911
Fixes: #24007