-
Notifications
You must be signed in to change notification settings - Fork 5.3k
stats: remove Stats::StorePtr alias #20911
Copy link
Copy link
Closed
Labels
area/statsno stalebotDisables stalebot from closing an issueDisables stalebot from closing an issuestalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recentlytech debt
Description
That is just an alias for StoreSharedPtr and all references in the repo to StorePtr have been removed, and a lint check added to prevent new ones from appearing.
However there are other repos that reference Stats::StorePtr and they need a chance to clean up their references. 2 I know of are internal to Google (CL pending) and Nighthawk -- code changed; haven't issued PR yet.
We should do a community-meeting call to remove refs to StorePtr first and then write the final PR to delete it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/statsno stalebotDisables stalebot from closing an issueDisables stalebot from closing an issuestalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recentlytech debt