bazel: fix missing framework on macOS#24802
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom Jan 7, 2023
Merged
Conversation
When using only the command line tools (not a full Xcode installation) on macOS, bazel does not pass `-fobjc-link-runtime` and therefore does not link to the CoreFoundation framework, which is required by absl. This adds the required framework, and makes this a linker error instead of a runtime error for the future. Fixes envoyproxy#24782 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
htuch
approved these changes
Jan 6, 2023
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
VishalDamgude
pushed a commit
to freshworks-oss/envoy
that referenced
this pull request
Feb 1, 2023
When using only the command line tools (not a full Xcode installation) on macOS, bazel does not pass -fobjc-link-runtime and therefore does not link to the CoreFoundation framework, which is required by absl. This adds the required framework, and makes this a linker error instead of a runtime error for the future. Fixes envoyproxy#24782 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: VishalDamgude <vishal.damgude@freshworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using only the command line tools (not a full Xcode installation) on macOS, bazel does not pass
-fobjc-link-runtimeand therefore does not link to the CoreFoundation framework, which is required by absl. This adds the required framework, and makes this a linker error instead of a runtime error for the future.Fixes #24782
Signed-off-by: Keith Smiley keithbsmiley@gmail.com