Skip to content

ci: Trigger mobile workflows on workflow change#24212

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:ci-mobile-ci-change
Nov 28, 2022
Merged

ci: Trigger mobile workflows on workflow change#24212
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:ci-mobile-ci-change

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Nov 25, 2022

If the workflow has changed but is not tested, it might break next time it actually is tested

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Nov 25, 2022

just to flag this is the kind of problem i was referring to with the "git diff and bail" pattern

with bazel, you have a hermetic principle and if everything sticks to it you can trust your inputs and bazel automatically blows the cache if it detects any change in them

with this type of pattern you are effectively managing the inputs manually which means that in all of the places you want to control program flow according to change you need to capture exactly the correct inputs/changes, and supposing you manage to do that, you then have to maintain them as different parts of the system change

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Nov 25, 2022

a similar example would be where the mobile part of the repo uses tooling from the envoy part of the repo - the tooling might change in the envoy part, which wont be detected as a mobile change and so wont get tested until the mobile part itself changes

(we might check and see that it doesnt pose any problem, but there is not guarantee that it will continue to do so)

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good call, thanks!

@phlax phlax merged commit c66450e into envoyproxy:main Nov 28, 2022
jpsim added a commit that referenced this pull request Nov 28, 2022
…st-xcode-14.1

* origin/main:
  Move Http1ParserImpl and pretty-printer to test_common/utility.h. (#24146)
  ci: Trigger mobile workflows on workflow change (#24212)

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request Nov 28, 2022
…obile-changes

* origin/main:
  ci: Pin mobile gh action Ubuntu images (#24201)
  Move Http1ParserImpl and pretty-printer to test_common/utility.h. (#24146)
  ci: Trigger mobile workflows on workflow change (#24212)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants