Move Http1ParserImpl and pretty-printer to test_common/utility.h.#24146
Merged
KBaichoo merged 3 commits intoenvoyproxy:mainfrom Nov 28, 2022
bencebeky:utility
Merged
Move Http1ParserImpl and pretty-printer to test_common/utility.h.#24146KBaichoo merged 3 commits intoenvoyproxy:mainfrom bencebeky:utility
KBaichoo merged 3 commits intoenvoyproxy:mainfrom
bencebeky:utility
Conversation
Consolidate these existing implementations. Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/assign @KBaichoo |
Contributor
Author
|
Kevin: PTAL. This is a test-only refactor with no behavior change. I'm open to alternate naming suggestions, naming is hard. Note that Http2Impl (oghttp2 and nghttp2) is both for parsing and serializing, whereas Http1ParserImpl (Balsa and http-parser) is only for parsing, hence the name difference. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate these existing implementations.
Tracking issue: #21245
Signed-off-by: Bence Béky bnc@google.com
Commit Message: Move Http1ParserImpl and pretty-printer to test_common/utility.h.
Additional Description:
Risk Level: low, test-only refactor
Testing: test-only change
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a