examples/front-proxy: base dockerfile on alpine#2326
Merged
junr03 merged 1 commit intoenvoyproxy:masterfrom Jan 9, 2018
Merged
examples/front-proxy: base dockerfile on alpine#2326junr03 merged 1 commit intoenvoyproxy:masterfrom
junr03 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Previously, the example wouldn't build due to the wrong version of python being used. Rather than go through the pain of installing a modern version of python on ubuntu:14.04, this patch just bases examples dockerfile on the envoy alpine image which includes the necessary version of python3 by default. Fixes envoyproxy#2262. Signed-off-by: Louis Taylor <louis@kragniz.eu>
Member
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* fixing postsubmit * fix post
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
To pull in bazelbuild/rules_apple#1478 ``` Envoy.xcframework ├── Info.plist ├── ios-arm64 │ ├── Envoy.a │ ├── Envoy.swiftmodule │ │ ├── arm64.swiftdoc │ │ └── arm64.swiftinterface │ └── Headers │ ├── Envoy.h │ └── module.modulemap └── ios-arm64_x86_64-simulator ├── Envoy.a ├── Envoy.swiftmodule │ ├── arm64.swiftdoc │ ├── arm64.swiftinterface │ ├── x86_64.swiftdoc │ └── x86_64.swiftinterface └── Headers ├── Envoy.h └── module.modulemap ``` Risk Level: Low Testing: Validated by pulling in this version in Xcode and running on device + simulator Docs Changes: N/A Release Notes: N/A Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
To pull in bazelbuild/rules_apple#1478 ``` Envoy.xcframework ├── Info.plist ├── ios-arm64 │ ├── Envoy.a │ ├── Envoy.swiftmodule │ │ ├── arm64.swiftdoc │ │ └── arm64.swiftinterface │ └── Headers │ ├── Envoy.h │ └── module.modulemap └── ios-arm64_x86_64-simulator ├── Envoy.a ├── Envoy.swiftmodule │ ├── arm64.swiftdoc │ ├── arm64.swiftinterface │ ├── x86_64.swiftdoc │ └── x86_64.swiftinterface └── Headers ├── Envoy.h └── module.modulemap ``` Risk Level: Low Testing: Validated by pulling in this version in Xcode and running on device + simulator Docs Changes: N/A Release Notes: N/A Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the example wouldn't build due to the wrong version of
python being used.
Rather than go through the pain of installing a modern version of python
on ubuntu:14.04, this patch just bases examples dockerfile on the envoy
alpine image which includes the necessary version of python3 by default.
Fixes #2262.
Risk Level: Low
Release Notes: N/A
Release Notes: N/A