Conversation
keith
referenced
this pull request
May 24, 2022
…le file names based directly on the inferred bundle name. PiperOrigin-RevId: 448546861
Member
Author
|
There were some test conflicts here which I picked the right version of for now but will have to be re-updated with #1447, it's fine they will fail because the numbers like |
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/616 (must be Lyft employee to view) |
segiddins
approved these changes
May 24, 2022
d8da817 to
9b40d93
Compare
…le file names based directly on the inferred bundle name. PiperOrigin-RevId: 448546861 (cherry picked from commit e9a8823)
9b40d93 to
0cfe9c4
Compare
jpsim
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
May 26, 2022
To pull in bazelbuild/rules_apple#1478 ``` Envoy.xcframework ├── Info.plist ├── ios-arm64 │ ├── Envoy.a │ ├── Envoy.swiftmodule │ │ ├── arm64.swiftdoc │ │ └── arm64.swiftinterface │ └── Headers │ ├── Envoy.h │ └── module.modulemap └── ios-arm64_x86_64-simulator ├── Envoy.a ├── Envoy.swiftmodule │ ├── arm64.swiftdoc │ ├── arm64.swiftinterface │ ├── x86_64.swiftdoc │ └── x86_64.swiftinterface └── Headers ├── Envoy.h └── module.modulemap ``` Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
May 26, 2022
To pull in bazelbuild/rules_apple#1478 ``` Envoy.xcframework ├── Info.plist ├── ios-arm64 │ ├── Envoy.a │ ├── Envoy.swiftmodule │ │ ├── arm64.swiftdoc │ │ └── arm64.swiftinterface │ └── Headers │ ├── Envoy.h │ └── module.modulemap └── ios-arm64_x86_64-simulator ├── Envoy.a ├── Envoy.swiftmodule │ ├── arm64.swiftdoc │ ├── arm64.swiftinterface │ ├── x86_64.swiftdoc │ └── x86_64.swiftinterface └── Headers ├── Envoy.h └── module.modulemap ``` Risk Level: Low Testing: Validated by pulling in this version in Xcode and running on device + simulator Docs Changes: N/A Release Notes: N/A Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
To pull in bazelbuild/rules_apple#1478 ``` Envoy.xcframework ├── Info.plist ├── ios-arm64 │ ├── Envoy.a │ ├── Envoy.swiftmodule │ │ ├── arm64.swiftdoc │ │ └── arm64.swiftinterface │ └── Headers │ ├── Envoy.h │ └── module.modulemap └── ios-arm64_x86_64-simulator ├── Envoy.a ├── Envoy.swiftmodule │ ├── arm64.swiftdoc │ ├── arm64.swiftinterface │ ├── x86_64.swiftdoc │ └── x86_64.swiftinterface └── Headers ├── Envoy.h └── module.modulemap ``` Risk Level: Low Testing: Validated by pulling in this version in Xcode and running on device + simulator Docs Changes: N/A Release Notes: N/A Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 448546861
(cherry picked from commit e9a8823)