test: Enable addFakeUpstream() to create AutonomousUpstreams#21908
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Jun 28, 2022
Merged
test: Enable addFakeUpstream() to create AutonomousUpstreams#21908alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Ali Beyad <abeyad@google.com>
Contributor
Author
|
/assign @alyssawilk |
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
auto-merge was automatically disabled
June 27, 2022 19:30
Head branch was pushed to by a user without write access
alyssawilk
approved these changes
Jun 28, 2022
alyssawilk
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 28, 2022
Pulls in envoyproxy/envoy#21908, which is needed to build the xDS integration tests in Envoy Mobile. Signed-off-by: Ali Beyad abeyad@google.com Signed-off-by: Ali Beyad <abeyad@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the BaseIntegrationTest::addFakeUpstream() function would only create a FakeUpstream, not taking
BaseIntegrationTest::autonomous_upstream_ into account. This could lead to confusing integration test behavior.
With this change, the addFakeUpstream() function takes a required autonomous_upstream parameter that
indicates whether an AutonomousUpstream should be created instead of a FakeUpstream.
Signed-off-by: Ali Beyad abeyad@google.com