Skip to content

'./tools/check_format.py check path/to/dir' fails #2391

@taiki45

Description

@taiki45

Description:
Passing subdir to 'tools/check_format.py check' will fail:

Repro steps:

$ /tools/check_format.py check source/common/stats
ERROR: header_order.py check failed for file: ./thread_local_store.cc
ERROR: header_order.py check failed for file: ./stats_impl.cc
ERROR: header_order.py check failed for file: ./grpc_metrics_service_impl.cc
ERROR: header_order.py check failed for file: ./statsd.cc
ERROR: check format failed. run 'tools/check_format.py fix'

While passing single file or passing nothing succeeds:

$ for f in $(find source/common/stats -type f); do ./tools/check_format.py check ${f}; done
./tools/check_format.py check

Metadata

Metadata

Assignees

No one assigned

    Labels

    beginnerGood starter issues!enhancementFeature requests. Not bugs or questions.help wantedNeeds help!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions