Skip to content

zone aware load_balancer does not handle some of the rounding problems in calculations.#214

Merged
RomanDzhabarov merged 4 commits intomasterfrom
fix_crash
Nov 13, 2016
Merged

zone aware load_balancer does not handle some of the rounding problems in calculations.#214
RomanDzhabarov merged 4 commits intomasterfrom
fix_crash

Conversation

@RomanDzhabarov
Copy link
Copy Markdown
Member

@RomanDzhabarov RomanDzhabarov commented Nov 12, 2016

Due to rounding errors we could end up in highly unlikely situation where we do not have left capacity to route.

Have a stat on that and return random zone in this case. We could potentially increase precision by using higher (than 10000) multiplier in calculations.

@lyft/network-team

@mattklein123
Copy link
Copy Markdown
Member

mattklein123 commented Nov 12, 2016

  1. Change PR title/commit message to something descriptive.
  2. Add test. If you need to factor stuff out into static helpers do that.

roman: fixed.

@RomanDzhabarov RomanDzhabarov changed the title Fix core dump. zone aware load_balancer does not handle some of the rounding problems in calculations. Nov 13, 2016
@RomanDzhabarov RomanDzhabarov merged commit e6fb9fa into master Nov 13, 2016
@RomanDzhabarov RomanDzhabarov deleted the fix_crash branch November 13, 2016 04:46
taiki45 pushed a commit to taiki45/data-plane-api that referenced this pull request Mar 15, 2018
- update_empty: envoyproxy/envoy#1688
- lb_zone_no_capacity_left: envoyproxy/envoy#214

Signed-off-by: Taiki Ono <taiki-ono@cookpad.com>
mandarjog pushed a commit to mandarjog/envoy that referenced this pull request May 15, 2020
…yproxy#214)

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Co-authored-by: John Plevyak <jplevyak@gmail.com>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Adding some details on the application lifecycle/network conditions investigation with Envoy on Android. I added sections for iOS so @rebello95 can integrate his findings here too.

Signed-off-by: Alan Chiu <achiu@lyft.com>

Description: device conditions analysis for Android
Risk Level: low
Testing: locally
Docs Changes: /performance/device_conditions.rst

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Adding some details on the application lifecycle/network conditions investigation with Envoy on Android. I added sections for iOS so @rebello95 can integrate his findings here too.

Signed-off-by: Alan Chiu <achiu@lyft.com>

Description: device conditions analysis for Android
Risk Level: low
Testing: locally
Docs Changes: /performance/device_conditions.rst

Signed-off-by: JP Simard <jp@jpsim.com>
arminabf pushed a commit to arminabf/envoy that referenced this pull request Jun 5, 2024
mathetake added a commit that referenced this pull request Mar 3, 2026
**Commit Message**:

- Organizing getting started docs for easy consumption
- Added a **Quickstart** option
- Changed the docs test. We will need to update so it covers more than
quickstart block later.
    - I have manually tested all other blocks across the pages.

**Related Issues/PRs**:

Fixes #29

---------

Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants