config: latch previous config on empty EDS/RDS update.#1688
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 19, 2017
Merged
config: latch previous config on empty EDS/RDS update.#1688htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
With ADS or other batched updates, we might not see a cluster/route config in an EDS/RDS update. There are at least two sane things to do; (1) latch the previous config (2) provide an empty config for the resource. In this PR, we opt for (1), this isn't on the happy path so there isn't an obvious choice either way. Signed-off-by: Harvey Tuch <htuch@google.com>
5ca26a2 to
caa8120
Compare
| } | ||
|
|
||
| void RdsRouteConfigProviderImpl::onConfigUpdate(const ResourceVector& resources) { | ||
| if (resources.empty()) { |
Member
There was a problem hiding this comment.
Doesn't this also apply to LDS/CDS also? I only see RDS/EDS. (Also, again not loving all the duplication but I know we have ticket on trying to consolidate).
Member
Author
There was a problem hiding this comment.
LDS/CDS empty responses should delete clusters and route configs, since they are always global and provide the source-of-truth on what the valid clusters/route configs are.
mattklein123
approved these changes
Sep 19, 2017
taiki45
pushed a commit
to taiki45/data-plane-api
that referenced
this pull request
Mar 15, 2018
- update_empty: envoyproxy/envoy#1688 - lb_zone_no_capacity_left: envoyproxy/envoy#214 Signed-off-by: Taiki Ono <taiki-ono@cookpad.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ADS or other batched updates, we might not see a cluster/route config in
an EDS/RDS update. There are at least two sane things to do; (1) latch the
previous config (2) provide an empty config for the resource. In this PR, we
opt for (1), this isn't on the happy path so there isn't an obvious choice
either way.
Signed-off-by: Harvey Tuch htuch@google.com