envoy.reloadable_features.use_observable_cluster_name deprecation#19475
Merged
zuercher merged 2 commits intoenvoyproxy:mainfrom Jan 18, 2022
Merged
envoy.reloadable_features.use_observable_cluster_name deprecation#19475zuercher merged 2 commits intoenvoyproxy:mainfrom
zuercher merged 2 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
requested changes
Jan 11, 2022
Member
Author
|
@adisuissa thanks for quick review, I will do it. |
69bd9f9 to
d7b4ace
Compare
d7b4ace to
a4d8f0d
Compare
adisuissa
requested changes
Jan 13, 2022
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
/lgtm api
Please add an entry to the release notes (https://github.com/envoyproxy/envoy/blob/main/docs/root/version_history/current.rst).
/wait
Member
Author
|
@adisuissa added, thanks. |
00ebb23 to
8488e27
Compare
Signed-off-by: Loong <loong.dai@intel.com>
8488e27 to
1573de3
Compare
Signed-off-by: Loong <loong.dai@intel.com>
adisuissa
approved these changes
Jan 18, 2022
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @zuercher |
zuercher
approved these changes
Jan 18, 2022
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
envoyproxy#19475) See envoyproxy#15139 ([cluster] Use alt_stat_name for general observability purposes (access log, tracing, admin)), which introduced a runtime guarded feature, which has been enabled by default for 6 months, so remove the old code path. Risk Level: Low Testing: n/a Docs Changes: updated Release Notes: Deprecate envoy.reloadable_features.use_observable_cluster_name. Platform Specific Features: n/a Signed-off-by: Loong <loong.dai@intel.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Loong loong.dai@intel.com
Commit Message:
#15139 ([cluster] Use alt_stat_name for general observability purposes (access log, tracing, admin)) introduced a runtime guarded feature, which has been 6 months since the new code has been exercised by default, so remove the old code path.
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes: Deprecate envoy.reloadable_features.use_observable_cluster_name.
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #18447
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]