[cluster] Use alt_stat_name for general observability purposes (access log, tracing, admin)#15139
Merged
asraa merged 10 commits intoenvoyproxy:mainfrom Mar 2, 2021
Merged
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Contributor
Author
|
@zuercher could you please take a look or assign to someone else? Also happy to split this up (although there is not too much complexity) |
Signed-off-by: Asra Ali <asraa@google.com>
Contributor
Author
|
@envoyproxy/api-shepherds could you PTAL for API changes? |
zuercher
previously approved these changes
Mar 1, 2021
mattklein123
previously approved these changes
Mar 1, 2021
Member
mattklein123
left a comment
There was a problem hiding this comment.
API LGTM modulo one typo I found (I think).
| * oauth filter: added the optional parameter :ref:`auth_scopes <envoy_v3_api_field_extensions.filters.http.oauth2.v3alpha.OAuth2Config.auth_scopes>` with default value of 'user' if not provided. Enables this value to be overridden in the Authorization request to the OAuth provider. | ||
| * perf: allow reading more bytes per operation from raw sockets to improve performance. | ||
| * router: extended custom date formatting to DOWNSTREAM_PEER_CERT_V_START and DOWNSTREAM_PEER_CERT_V_END when using :ref:`custom request/response header formats <config_http_conn_man_headers_custom_request_headers>`. | ||
| * tracing: added `upstream_address.name` tag that resolves to resolve to :ref:`alt_stat_name <envoy_v3_api_field_config.cluster.v3.Cluster.alt_stat_name>` if provided (and otherwise the cluster name). |
Member
There was a problem hiding this comment.
Suggested change
| * tracing: added `upstream_address.name` tag that resolves to resolve to :ref:`alt_stat_name <envoy_v3_api_field_config.cluster.v3.Cluster.alt_stat_name>` if provided (and otherwise the cluster name). | |
| * tracing: added `upstream_cluster.name` tag that resolves to resolve to :ref:`alt_stat_name <envoy_v3_api_field_config.cluster.v3.Cluster.alt_stat_name>` if provided (and otherwise the cluster name). |
?
Contributor
Author
|
@zuercher sorry for the re-ping, the typo-fix dropped the LGTM but I think this is ready to merge! |
zuercher
approved these changes
Mar 2, 2021
zuercher
pushed a commit
that referenced
this pull request
Jan 18, 2022
#19475) See #15139 ([cluster] Use alt_stat_name for general observability purposes (access log, tracing, admin)), which introduced a runtime guarded feature, which has been enabled by default for 6 months, so remove the old code path. Risk Level: Low Testing: n/a Docs Changes: updated Release Notes: Deprecate envoy.reloadable_features.use_observable_cluster_name. Platform Specific Features: n/a Signed-off-by: Loong <loong.dai@intel.com>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
envoyproxy#19475) See envoyproxy#15139 ([cluster] Use alt_stat_name for general observability purposes (access log, tracing, admin)), which introduced a runtime guarded feature, which has been enabled by default for 6 months, so remove the old code path. Risk Level: Low Testing: n/a Docs Changes: updated Release Notes: Deprecate envoy.reloadable_features.use_observable_cluster_name. Platform Specific Features: n/a Signed-off-by: Loong <loong.dai@intel.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Re-purpose
alt_stat_namefor other observability use-cases: access logging, tracing, and admin dumps.Additional Description:
ClusterInfois added,observabilityName()that is thealt_stat_nameif provided, and otherwise the Cluster name.%UPSTREAM_CLUSTER%resolves toobservabilityName().upstream_cluster.nameis added to referenceobservabilityName().config_dumpin the cluster configuration. TheClusterStatusadds theobservability_namefield.Risk Level: Low, just adds observability.
Testing: Added tests for access logging with/without runtime feature enabled.
Docs Changes: Added doc changes to Access Log page, Tracing page.
Release Notes: Added release notes for all three new uses cases.
Fixes: #14309
Runtime guard: Added runtime guard
envoy.reloadable_features.use_observable_cluster_namethat controls whether formatter%UPSTREAM_CLUSTER% resolves to original cluster name oralt_stat_name.API considerations: Tagged
alt_stat_namefor general purpose renameobservability_name.