Few small fixes to allow envoy to compile on ARM32#1795
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 2, 2017
Merged
Few small fixes to allow envoy to compile on ARM32#1795mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Tested compilation for rasbperry pi and android (the 'endian' change is required for android NDK - recent androids can compile with 64 bit). Signed-off-by: Costin Manolache <costin@google.com>
mattklein123
approved these changes
Oct 2, 2017
Contributor
|
|
Contributor
Author
|
Ops, it is required on android - I'll add an ifdef.
…On Tue, Oct 3, 2017 at 3:25 PM, Colin Rafferty ***@***.***> wrote:
#include <endian> doesn't exist on OS X.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1795 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFI6s3SsU7hwAOKKqts6jFaa_1DFm-sks5sorRIgaJpZM4PrVzs>
.
|
Contributor
Author
|
Sorry for the breakage - since it was just an experiment on using envoy on android, and it doesn't really need mongodb - no need to complicate things with an ifdef, the PR removing it is enough. |
Contributor
|
No big deal -- there was another unrelated os x breakage, and 1804 keeps your change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested compilation for rasbperry pi and android (the 'endian' change is
required for android NDK - recent androids can compile with 64 bit).
(moved from PR #1781 due to git squashing/DCO issues)
Signed-off-by: Costin Manolache costin@google.com