fix OS X build#1804
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 4, 2017
craffert0:master
Merged
Conversation
Signed-off-by: Colin Rafferty <crafferty@lyft.com>
mattklein123
approved these changes
Oct 4, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Use jwt_auth config from istio/api * Update api sha
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
<endian>doesn't exist on OS X. Fixed byte_order.h to properly include it when not OS X, and fixed bson_impl.cc to not know about endian.h.envoy_select_hot_restart. Like not attempting to run on OS X.ps. byte_order.h had a completely unused
namespace Envoywrapping the macros. I ditched it because it's correct.