dns: use dns specific log component, add log events to apple resolver#17833
Merged
ggreenway merged 3 commits intoenvoyproxy:mainfrom Aug 26, 2021
Merged
dns: use dns specific log component, add log events to apple resolver#17833ggreenway merged 3 commits intoenvoyproxy:mainfrom
ggreenway merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Augustyniak
previously approved these changes
Aug 24, 2021
| AppleDnsResolverImpl::startResolution(const std::string& dns_name, | ||
| DnsLookupFamily dns_lookup_family, ResolveCb callback) { | ||
| ENVOY_LOG(debug, "DNS resolver resolve={}", dns_name); | ||
| ENVOY_LOG_EVENT(debug, "apple_dns_started", "DNS resolution for {} started", dns_name); |
Contributor
There was a problem hiding this comment.
Suggested change
| ENVOY_LOG_EVENT(debug, "apple_dns_started", "DNS resolution for {} started", dns_name); | |
| ENVOY_LOG_EVENT(debug, "apple_dns_start", "DNS resolution for {} started", dns_name); |
To keep it a noun (as with other cases in this file)
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
|
/retest for pipeline flake |
|
Retrying Azure Pipelines: |
junr03
previously approved these changes
Aug 25, 2021
Member
junr03
left a comment
There was a problem hiding this comment.
lgtm pending @Augustyniak suggestion
Signed-off-by: Snow Pettersen <snowp@lyft.com>
buildbreaker
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Aug 28, 2021
Pulls in several instrumentation changes that make use of `ENVOY_LOG_EVENT`: - envoyproxy/envoy#17879 - envoyproxy/envoy#17833 - envoyproxy/envoy#17853 Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the c-ares and apple DNS resolver to use their own logging component and adds additional ENVOY_LOG_EVENT logs to the apple resolver to match the c-ares one.
Signed-off-by: Snow Pettersen snowp@lyft.com
Commit Message:
Additional Description:
Risk Level: Low, only changes logging
Testing: n/a
Docs Changes: n/a
Release Notes: n/a