Merged
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
cc @bitcoinland |
htuch
approved these changes
Sep 28, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
Signed-off-by: Matt Klein <mklein@lyft.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, the deletion event of AIGatewayRoute was't propagated to Gateway pod mutations, hence the Gateway pods would remain having the extproc side car until the reconciliation happens naturally next time (e.g. changing the resource config etc). This fixes it. **Related Issues/PRs (if applicable)** Closes #1760 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Klein mklein@lyft.com