Fix implicit string -> bool conversion#1705
Merged
RomanDzhabarov merged 1 commit intoenvoyproxy:masterfrom Sep 20, 2017
Merged
Conversation
string. Signed-off-by: Trevor Schroeder <trevors@google.com>
mattklein123
approved these changes
Sep 20, 2017
htuch
approved these changes
Sep 20, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…1705) Description: Move the Java/Kotlin MacOS part of the android_test workflow to Engflow's remote execution and improve build times by ~10x The remaining android_test Linux workflow requires some Java setup so it'll be done in a subsequent PR Risk Level: Low Testing: See android_build and android_test checks Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…1705) Description: Move the Java/Kotlin MacOS part of the android_test workflow to Engflow's remote execution and improve build times by ~10x The remaining android_test Linux workflow requires some Java setup so it'll be done in a subsequent PR Risk Level: Low Testing: See android_build and android_test checks Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
) **Description** This is a draft introduced in #1699 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
true == true
"true" == true
false == false
"false" == true
:)