Add tests to cover HTTP health checker callbacks#1699
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Sep 20, 2017
Merged
Add tests to cover HTTP health checker callbacks#1699mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
Ensure that HttpHealthCheckerImpl::HttpActiveHealthCheckSession's Http::StreamCallbacks implementations are sane. Though the called functions are still no-ops, they are now no-ops that are covered by tests. Signed-off-by: Alex Konradi <akonradi@google.com>
Ensure that the no-op high-water-mark callback implementations for HttpHealthCheckerImpl::HttpActiveHealthCheckSession::ConnectionCallbackImpl are sane. They are still no-ops, but now they're covered by tests. Signed-off-by: Alex Konradi <akonradi@google.com>
| EXPECT_CALL(*test_sessions_[0]->interval_timer_, enableTimer(_)); | ||
| EXPECT_CALL(*test_sessions_[0]->timeout_timer_, disableTimer()); | ||
|
|
||
| for (auto* callback : test_sessions_[0]->request_encoder_.stream_.callbacks_) { |
Member
There was a problem hiding this comment.
nit: I might add runHighWatermarkCallbacks() and runLowWatermarkCallbacks() here: https://github.com/envoyproxy/envoy/blob/master/test/mocks/http/mocks.h#L153. We may want to use this elsewhere in the future and we can put the loop inside the mock.
Signed-off-by: Alex Konradi <akonradi@google.com>
| EXPECT_CALL(*test_sessions_[0]->interval_timer_, enableTimer(_)); | ||
| EXPECT_CALL(*test_sessions_[0]->timeout_timer_, disableTimer()); | ||
|
|
||
| for (auto* callback : test_sessions_[0]->client_connection_->callbacks_) { |
Member
There was a problem hiding this comment.
Sorry can you do same thing here also? Thanks. (There are already event helpers IIRC).
Contributor
Author
There was a problem hiding this comment.
Oops, forgot about those ones.
Contributor
Author
There was a problem hiding this comment.
I found helpers in the ConnectionImpl class but not in the mock class
Member
There was a problem hiding this comment.
https://github.com/envoyproxy/envoy/pull/1699/files#diff-e96d2141e2131be66d0db09f98bd4a16R32. Can you move there as it applies to both types of connections?
Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Updates Android filter interfaces to support receiving StreamIntel on callbacks. Underlying data is not yet populated. Risk Level: Low Testing: Local & CI Docs Changes: Pending Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Updates Android filter interfaces to support receiving StreamIntel on callbacks. Underlying data is not yet populated. Risk Level: Low Testing: Local & CI Docs Changes: Pending Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This refactors tests/extproc integration tests: 1. Renamed as tests/data-plane to be usable for Dynamic Module too #1564 2. Extract tests/extproc/mcp into tests/data-plane-mcp to have a separate concern in each integration tests **Related Issues/PRs (if applicable)** Preparation for #90 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
) **Description** This is a draft introduced in #1699 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods under test are no-ops, but are not covered by any existing tests. Add some simple sanity checks to make sure that the callbacks don't blow anything up if high water marks are reached.