runtime: remove HCM stream error runtime override#16040
Merged
asraa merged 6 commits intoenvoyproxy:mainfrom Apr 22, 2021
Merged
runtime: remove HCM stream error runtime override#16040asraa merged 6 commits intoenvoyproxy:mainfrom
asraa merged 6 commits intoenvoyproxy:mainfrom
Conversation
Remove envoy.reloadable_features.hcm_stream_error_on_invalid_message now that it is old enough. Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
Contributor
Author
|
/assign @alyssawilk |
Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
asraa
previously approved these changes
Apr 20, 2021
Contributor
asraa
left a comment
There was a problem hiding this comment.
Thanks! Needs a main merge :(
/wait
…e-runtime-guard-16007 Signed-off-by: Alex Konradi <akonradi@google.com>
asraa
previously approved these changes
Apr 20, 2021
Contributor
|
I think something conflicted again! (a merged PR in the meantime?) :( Release note merges are the worst |
…e-runtime-guard-16007 Signed-off-by: Alex Konradi <akonradi@google.com>
Contributor
Author
|
It was probably my other cleanup PR, #16041 |
asraa
approved these changes
Apr 22, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
* Remove HCM stream error runtime override. Remove envoy.reloadable_features.hcm_stream_error_on_invalid_message now deprecated Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove HCM stream error runtime override
Additional Description:
Remove envoy.reloadable_features.hcm_stream_error_on_invalid_message now
that it is old enough.
Risk Level: low
Testing: ran affected tests
Docs Changes: none
Release Notes: document removed override
Platform Specific Features: none
Fixes #16007