overload: remove override for http/2 goaway#16041
Merged
antoniovicente merged 3 commits intoenvoyproxy:mainfrom Apr 20, 2021
Merged
overload: remove override for http/2 goaway#16041antoniovicente merged 3 commits intoenvoyproxy:mainfrom
antoniovicente merged 3 commits intoenvoyproxy:mainfrom
Conversation
Remove deprecated override envoy.reloadable_features.overload_manager_disable_keepalive_drain_http2. Multiplexing HTTP connections (HTTP/2, HTTP/3) will always be sent a GOAWAY when the overload action for disabling connection keepalive triggers. Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
antoniovicente
previously approved these changes
Apr 19, 2021
Contributor
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for removing the obsolete runtime guard.
Contributor
|
@akonradi seems like a conflict sneaked in, please merge main. /wait |
…e-runtime-guard-16010 Signed-off-by: Alex Konradi <akonradi@google.com>
antoniovicente
approved these changes
Apr 20, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Remove deprecated runtime override envoy.reloadable_features.overload_manager_disable_keepalive_drain_http2. Multiplexing HTTP connections (HTTP/2, HTTP/3) will always be sent a GOAWAY when the overload action for disabling connection keepalive triggers. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove envoy.reloadable_features.overload_manager_disable_keepalive_drain_http2
Additional Description:
Multiplexing HTTP connections (HTTP/2, HTTP/3) will always be sent a GOAWAY when the overload action for disabling connection keepalive triggers.
Risk Level: low
Testing: ran affected tests
Docs Changes: n/a
Release Notes: documented removed override
Platform Specific Features: n/a
Fixes #16010