Skip to content

fix OSX build#1584

Merged
mattklein123 merged 2 commits intomasterfrom
fix_osx_build
Sep 1, 2017
Merged

fix OSX build#1584
mattklein123 merged 2 commits intomasterfrom
fix_osx_build

Conversation

@mattklein123
Copy link
Copy Markdown
Member

No description provided.

danielhochman
danielhochman previously approved these changes Sep 1, 2017
RomanDzhabarov
RomanDzhabarov previously approved these changes Sep 1, 2017
Copy link
Copy Markdown
Member

@RomanDzhabarov RomanDzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mattklein123 mattklein123 merged commit c382686 into master Sep 1, 2017
@mattklein123 mattklein123 deleted the fix_osx_build branch September 1, 2017 01:59
mathetake added a commit that referenced this pull request Mar 3, 2026
**Description**
This consolidates all the copy-pasted processors that existed per
endpoint we support into one generic processor. This was made possible
thanks to the series of refactoring that we landed in the past few weeks
primarily for dynamic module work #90.

Notably, now in order to add an endpoint, majority of the new code will
be in translator (where also have shared generic interface) as well as
the type definition. No longer it requires the huge copy paste of
processors.

**Related Issues/PRs (if applicable)**

Resolves #1083 
Blocker for #1429 #1584 #1592 #1594

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: Ignasi Barrera <ignasi@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants