test: fix implicit fallthrough#1429
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 10, 2017
Merged
Conversation
htuch
previously approved these changes
Aug 10, 2017
test/test_common/environment.cc
Outdated
Member
There was a problem hiding this comment.
I don't think this actually makes sense given the context? Should probably be break here and below?
Contributor
Author
There was a problem hiding this comment.
/me wasn't paying attention to the case, but just that it was implicitly falling through...
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
a893cd2 to
339221c
Compare
Contributor
Author
|
updated |
mattklein123
approved these changes
Aug 10, 2017
htuch
approved these changes
Aug 10, 2017
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
May 4, 2024
Amend github issue envoyproxy#1429
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This consolidates all the copy-pasted processors that existed per endpoint we support into one generic processor. This was made possible thanks to the series of refactoring that we landed in the past few weeks primarily for dynamic module work #90. Notably, now in order to add an endpoint, majority of the new code will be in translator (where also have shared generic interface) as well as the type definition. No longer it requires the huge copy paste of processors. **Related Issues/PRs (if applicable)** Resolves #1083 Blocker for #1429 #1584 #1592 #1594 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com