Skip to content

docs: add automake to OS X build instructions#1568

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
gkhom:build-docs
Aug 29, 2017
Merged

docs: add automake to OS X build instructions#1568
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
gkhom:build-docs

Conversation

@gkhom
Copy link
Copy Markdown

@gkhom gkhom commented Aug 29, 2017

When trying to run the build on OS X (10.12.6) following the build instructions in bazel/README.md I encountered a failure when running bazel fetch //source/... to fetch and build all external dependencies.

The output contained the following logs:

++ 1504041217.N ./buildconf
buildconf: running libtoolize
buildconf: converting all mv to mv -f in local m4/libtool.m4
buildconf: running aclocal
./buildconf: line 217: aclocal: command not found
buildconf: aclocal command failed

As aclocal is part of automake, running the following command fixed the failure:

brew install automake

This PR adds this command to the build instructions.

@mattklein123
Copy link
Copy Markdown
Member

Thanks for fixing! Please sign CLA and we can merge.

@gkhom
Copy link
Copy Markdown
Author

gkhom commented Aug 29, 2017

@mattklein123 Thanks, I've signed the CLA.

@mattklein123 mattklein123 merged commit 2f92727 into envoyproxy:master Aug 29, 2017
jpsim pushed a commit that referenced this pull request Nov 28, 2022
* update envoy: f2906f5 & skip waiting on stats cluster warmup

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
* update envoy: f2906f5 & skip waiting on stats cluster warmup

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
#1568)

**Description**

This fixes the inconsistency of span usage by image gen and rerank
translators

**Related Issues/PRs (if applicable)**
Preparation for #90 
Follow up on #1565 #1567

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants