Skip to content

ci: small docker changes for local dev#1567

Merged
mattklein123 merged 1 commit intomasterfrom
docker_changes
Aug 29, 2017
Merged

ci: small docker changes for local dev#1567
mattklein123 merged 1 commit intomasterfrom
docker_changes

Conversation

@mattklein123
Copy link
Copy Markdown
Member

  1. Pass --rm to run_envoy_docker() to clean up container when finished.
  2. Allow NUM_CPUS to be overridden.

1) Pass --rm to run_envoy_docker().
2) Allow NUM_CPUS to be overriden.
@mattklein123
Copy link
Copy Markdown
Member Author

@htuch

@mattklein123 mattklein123 merged commit 419b26e into master Aug 29, 2017
@mattklein123 mattklein123 deleted the docker_changes branch August 29, 2017 22:37
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: This PR (which picks up work started on #1567) adds outlier detection to all configured clusters.

The main objective of this configuration is to drain connections that are perceived to be "dead" so that the cluster is forced to establish a new connection for future streams.

Currently the outlier detector will not eject already ejected hosts. And host ejection is what causes connection drain. In mobile, the desire is not to keep hosts ejected, but rather to cycle the underlying upstream connections. Hence the short base/max ejection time and the the tight unejection interval. The unejection interval is not any tighter because to balance timer churn.

The idea with the current configuration is that most, if not all "dead" connections will be reaped without having any adverse performance issues. Lyft will deploy and analyze production data to further tune the configuration. If ultimately different detector behavior (drain connections even if host is ejected) is desired, we can work to add to upstream envoy.

Risk Level:
Testing: This configuration was tested with the existing example apps pointed to a server that continuously returns 503. Expected host ejection, connection drain, host unejection behavior was observed.

Signed-off-by: Jose Nino jnino@lyft.com
Co-authored-by: Mike Schore mike.schore@gmail.com
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: This PR (which picks up work started on #1567) adds outlier detection to all configured clusters.

The main objective of this configuration is to drain connections that are perceived to be "dead" so that the cluster is forced to establish a new connection for future streams.

Currently the outlier detector will not eject already ejected hosts. And host ejection is what causes connection drain. In mobile, the desire is not to keep hosts ejected, but rather to cycle the underlying upstream connections. Hence the short base/max ejection time and the the tight unejection interval. The unejection interval is not any tighter because to balance timer churn.

The idea with the current configuration is that most, if not all "dead" connections will be reaped without having any adverse performance issues. Lyft will deploy and analyze production data to further tune the configuration. If ultimately different detector behavior (drain connections even if host is ejected) is desired, we can work to add to upstream envoy.

Risk Level:
Testing: This configuration was tested with the existing example apps pointed to a server that continuously returns 503. Expected host ejection, connection drain, host unejection behavior was observed.

Signed-off-by: Jose Nino jnino@lyft.com
Co-authored-by: Mike Schore mike.schore@gmail.com
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
**Description**

This fixes the inconsistency for embeddings in the span usage in
translators.

**Related Issues/PRs (if applicable)**
Preparation for #90
Follow up on #1565

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
#1568)

**Description**

This fixes the inconsistency of span usage by image gen and rerank
translators

**Related Issues/PRs (if applicable)**
Preparation for #90 
Follow up on #1565 #1567

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants