extension: User space event by lambdai · Pull Request #14712 · envoyproxy/envoy

lambdai · 2021-01-15T00:09:09Z

Commit Message:
UserSpaceFileEventImpl provides 3 functions

setEnabled(events) declared by FileEvent. The events are registered for callback. Each call detects fired events once, and IO handle will notify the new events in the long run.
activate(events). Explicitly activate the events. The above enabling events are not honored.
activateIfEnabled(events). It should only be used by IO handle. Unlike activate, poll honors the setEnabled. Will schedule callback if there is no pending callback.

Additional Description:
Part of #13418
Risk Level: LOW all codes are in extension
Testing: Mocked userspace io handle to unit test userspace event.
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

antoniovicente

Looks pretty good. Thanks so much for splitting this off and sending it out for review before the full change.

source/extensions/extensions_build_config.bzl

source/extensions/io_socket/user_space_io_socket/peer_buffer.h

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.h

source/extensions/io_socket/user_space_io_socket/BUILD

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.h

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.cc

test/extensions/io_socket/user_space_io_socket/user_space_file_event_impl_test.cc

lambdai

1 round update. Namespace name dedup and inner class comes later

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.cc

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.h

test/extensions/io_socket/user_space_io_socket/user_space_file_event_impl_test.cc

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.h

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.cc

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai · 2021-01-22T21:18:35Z

@antoniovicente ready to be reviewed now

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

source/extensions/io_socket/user_space_io_socket/user_space_file_event_impl.cc

source/extensions/io_socket/user_space/config.h

source/extensions/io_socket/user_space/file_event_impl.cc

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

test/per_file_coverage.sh

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

antoniovicente

Thanks!

test/per_file_coverage.sh

source/extensions/io_socket/user_space/file_event_impl.cc

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai · 2021-01-26T19:44:55Z

/assign @mattklein123

lambdai · 2021-01-26T19:47:21Z

The latest commit dismissed the approval though. That commit is merely a trivial comment update.

antoniovicente · 2021-01-27T17:20:36Z

Matt is on paternity leave. @envoyproxy/senior-maintainers could one of you take a look?

ggreenway

Looks good overall. I'm excited to see this feature moving forward!

source/extensions/io_socket/user_space/file_event_impl.h

source/extensions/io_socket/user_space/file_event_impl.cc

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai · 2021-01-29T20:01:35Z

@ggreenway Thanks! I address the included headers and also cleaned the bazel deps.

ggreenway

LGTM

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai · 2021-02-01T17:53:03Z

@ggreenway I believe the failing macos test is unrelated. It's failing consistently on other merged PRs.
What is the missing part to merge this PR? Thanks!

ggreenway · 2021-02-01T18:10:00Z

Mac CI fix was merged an hour ago. Please merge main and try again, and it should work.

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai · 2021-02-01T21:57:48Z

@ggreenway All green now!

moderation · 2021-02-02T00:52:45Z

Interested in what this functionally is for. Userspace QUIC for HTTP/3? For use with gVisor's userspace Netstack? Something else?

antoniovicente · 2021-02-02T01:10:53Z

See #11725

This is a step towards generalized connect handling; one use case could be access to internal listeners which are reachable via HTTP CONNECT, and support of the CONNECT method over HTTP2.

Introduce user space io socket handle on top of user space event at #14712 Userspace Io socket handles are always created with a peering handle. The write() methods populate the buffer in the peer handle. The read() methods consume the owned buffer. Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai added 5 commits January 14, 2021 15:08

format

121fb1b

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

renaming

192ed50

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

renaming: buffered to user_space

57b2810

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

remove io handle

852c467

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

more test

b3f0d12

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai requested a review from antoniovicente January 15, 2021 00:09

htuch assigned antoniovicente Jan 15, 2021

massage extensions doc

7da5697

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

Base automatically changed from master to main January 15, 2021 23:02

antoniovicente reviewed Jan 20, 2021

View reviewed changes

antoniovicente added the waiting label Jan 20, 2021

lambdai commented Jan 22, 2021

View reviewed changes

fixing naming and test

6d64221

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

repokitteh-read-only bot removed the waiting label Jan 22, 2021

lambdai added 2 commits January 22, 2021 12:51

remove duplicated user_space or io_handle

97a8013

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

extension convension and more format

35f3066

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

fix copy paste error

9f8fafd

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

antoniovicente reviewed Jan 22, 2021

View reviewed changes

source/extensions/io_socket/user_space/file_event_impl.cc Outdated Show resolved Hide resolved

Add test case that Closed implies Read

e4c7e87

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

antoniovicente reviewed Jan 23, 2021

View reviewed changes

test/per_file_coverage.sh Show resolved Hide resolved

not impl emulate edge

7a6b91a

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

antoniovicente previously approved these changes Jan 25, 2021

View reviewed changes

test/per_file_coverage.sh Show resolved Hide resolved

source/extensions/io_socket/user_space/file_event_impl.cc Outdated Show resolved Hide resolved

EOS to end-of-stream

67934cd

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai dismissed antoniovicente’s stale review via 67934cd January 25, 2021 22:32

Merge branch 'main' into userspaceevent

bc0b921

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

repokitteh-read-only bot assigned mattklein123 Jan 26, 2021

antoniovicente previously approved these changes Jan 27, 2021

View reviewed changes

ggreenway assigned ggreenway and unassigned mattklein123 Jan 28, 2021

ggreenway requested changes Jan 29, 2021

View reviewed changes

source/extensions/io_socket/user_space/file_event_impl.h Outdated Show resolved Hide resolved

source/extensions/io_socket/user_space/file_event_impl.h Outdated Show resolved Hide resolved

source/extensions/io_socket/user_space/file_event_impl.cc Show resolved Hide resolved

ggreenway added the waiting label Jan 29, 2021

strip headers and bazel dep

510c2be

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

lambdai dismissed antoniovicente’s stale review via 510c2be January 29, 2021 20:01

repokitteh-read-only bot removed the waiting label Jan 29, 2021

ggreenway approved these changes Jan 29, 2021

View reviewed changes

Merge branch 'main' into userspaceevent

7fe7df9

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

Merge branch 'main' into userspaceevent

81a8a4f

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

ggreenway merged commit 8e2286b into envoyproxy:main Feb 1, 2021

lambdai mentioned this pull request Feb 2, 2021

extension: User space io socket #14917

Merged

lambdai mentioned this pull request Feb 17, 2021

Io socket handle for internal socket #13418

Closed

Conversation

lambdai commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antoniovicente left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lambdai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lambdai commented Jan 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antoniovicente left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lambdai commented Jan 26, 2021

Uh oh!

lambdai commented Jan 26, 2021

Uh oh!

antoniovicente commented Jan 27, 2021

Uh oh!

ggreenway left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lambdai commented Jan 29, 2021

Uh oh!

ggreenway left a comment

Choose a reason for hiding this comment

Uh oh!

lambdai commented Feb 1, 2021

Uh oh!

ggreenway commented Feb 1, 2021

Uh oh!

lambdai commented Feb 1, 2021

Uh oh!

moderation commented Feb 2, 2021

Uh oh!

antoniovicente commented Feb 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lambdai commented Jan 15, 2021 •

edited

Loading